vaev-driver: Handle correctly HTML/BODY backgrounds. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Louciole
force-pushed
the
root-elements-bg-lou
branch
6 times, most recently
from
5973cab to
b826fbc
Compare
Louciole
force-pushed
the
root-elements-bg-lou
branch
from
b826fbc to
805b036
Compare
Louciole
commented
Mar 26, 2025
sleepy-monax
requested changes
Mar 26, 2025
src/web/vaev-layout/builder.cpp
Outdated
| @@ -175,7 +175,7 @@ static void _buildRun(Style::Computer& c, Gc::Ref<Dom::Text> node, Box& parent) | |||
| } | |||
| } | |||
|
|
|||
| parent.add({style, fontFace, std::move(prose)}); | |||
| parent.add({style, fontFace, std::move(prose), Gc::Ptr<Dom::Element> {}}); | |||
src/web/vaev-layout/builder.cpp
Outdated
| @@ -313,6 +314,7 @@ export Box build(Style::Computer& c, Gc::Ref<Dom::Document> doc) { | |||
| return { | |||
| style, | |||
| _lookupFontface(c.fontBook, *style), | |||
| Gc::Ptr<Dom::Element> {} | |||
src/web/vaev-layout/builder.cpp
Outdated
Comment on lines
340
to
343
| return {style, fontFace, prose, Gc::Ptr<Dom::Element> {}}; | ||
| } | ||
|
|
||
| return {style, fontFace}; | ||
| return {style, fontFace, Gc::Ptr<Dom::Element> {}}; |
src/web/vaev-base/color.h
Outdated
|
|
||
| constexpr bool operator==(ColorSpace const& other) const { | ||
| return type == other.type; | ||
| } | ||
| }; |
src/web/vaev-base/color.h
Outdated
Comment on lines
206
to
207
|
|
||
| bool operator==(Side const& other) const = default; |
src/web/vaev-base/color.h
Outdated
Comment on lines
217
to
211
|
|
||
| bool operator==(ColorMix const& other) const = default; | ||
| }; |
Louciole
force-pushed
the
root-elements-bg-lou
branch
from
805b036 to
1962e74
Compare
Louciole
force-pushed
the
root-elements-bg-lou
branch
2 times, most recently
from
9034707 to
e9f0290
Compare
Louciole
force-pushed
the
root-elements-bg-lou
branch
from
e9f0290 to
71f9db0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.